Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update classpath settings: overhaul to fix multiple issues #497

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Update classpath settings: overhaul to fix multiple issues #497

merged 2 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. ClasspathComputer: add tests for classpath computation 

    Failing tests for these issues:
* erroneous exception "Build path contains duplicate entry"
* updating source attachment changed unrelated attributes
* failed to preserve some existing attributes
* failed to preserve entries of kind="var"
* failed to preserve existing order
* UpdateClasspathJob returned CANCEL on success

Additional tests for existing behavior:
* from scratch, create lib entries with exported="true"
* from scratch, create classpath in some specific order
* set TEST attributes when plugin name matches test_plugin_pattern
    @haubi @HannesWell
    haubi authored and HannesWell committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    73bb2ed View commit details
    Browse the repository at this point in the history

  2. ClasspathComputer: overhaul classpath computation 

    Issues fixed:
* erroneous exception "Build path contains duplicate entry"
* updating source attachment changed unrelated attributes
* failed to preserve some existing attributes
* failed to preserve entries of kind="var"
* failed to preserve existing order
* UpdateClasspathJob returned CANCEL on success
* drop now unused yet public method createEntryUsingPreviousEntry

Tests now succeed, and run as part of AllPDEMinimalTests suite
    @haubi @HannesWell
    haubi authored and HannesWell committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    53637ee View commit details
    Browse the repository at this point in the history