Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add a version if exporting a package #1426 #1498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always add a version if exporting a package #1426 #1498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ....eclipse.pde.core/text/org/eclipse/pde/internal/core/text/bundle/ImportPackageObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"[" + version.getMajor() + "." + version.getMinor() + "," + (version.getMajor() + 1) + ")") //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$//$NON-NLS-4$
.toString();
}
return null;
return "[1.0.0)";

Check warning on line 42 in ui/org.eclipse.pde.core/text/org/eclipse/pde/internal/core/text/bundle/ImportPackageObject.java

View check run for this annotation

Jenkins - eclipse-pde / Compiler and API Tools

NLS 

NORMAL:
$
Non-externalized string literal; it should be followed by //$NON-NLS-
}

public ImportPackageObject(ManifestHeader header, ManifestElement element, String versionAttribute) {
Expand Down
Loading