fix NPE for ReferenceAnalyzer.fIndexedDetectors null #1289 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
approved these changes
Jun 5, 2024
jukzi
force-pushed
the
NPEapi
branch
2 times, most recently
from
6d6875f to
27c4799
Compare
HannesWell
reviewed
Jun 5, 2024
| try { | ||
| // build problem detectors | ||
| IApiProblemDetector[] detectors = buildProblemDetectors(component, ProblemDetectorBuilder.K_ALL, |
There was a problem hiding this comment.
Is there a reason why you moved this into the try-catch-block?
There was a problem hiding this comment.
sure: the final block cleans up a field that is initialized somewhen within "buildProblemDetectors". Any exception after initializing the field would leave a leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1289