Support selection of Bndtools Template in PDE Project Wizards

[laeubi]

PDE already offers a templating mechanism based on extension points, BndTools has one as well that is based on services.

This is an attempt to make BndTools based items available for the new automatic manifest generation that currently lacks any wizards.

Fix

• Support for automatic manifest generation: Feature request: BND templates for newly created bundles #704

Will require

• Add bndtools API for templating eclipse-platform/eclipse.platform.releng.aggregator#1611
• Add jakarta.activation-api to the target eclipse-platform/eclipse.platform.releng.aggregator#1670
• Add bnd templates template to feature #992
• Import template classes / resources from Bndtools and restore header #999
• Add data URL handler to equinox common eclipse-equinox/equinox#416

This is how it currently looks like

Create an own template project

Peek.2024-01-22.13-36.mp4

Use that template project to create other project from that template

Peek.2024-01-22.13-43.mp4

[github-actions]

Test Results

   277 files  ±0     277 suites  ±0   58m 40s ⏱️ + 4m 31s
 3 498 tests ±0   3 462 ✅ ±0   36 💤 ±0  0 ❌ ±0 
10 625 runs  ±0  10 523 ✅ ±0  102 💤 ±0  0 ❌ ±0 

Results for commit 76bde5a. ± Comparison against base commit 25a06e7.

♻️ This comment has been updated with latest results.

[akurtakov]

Comment is for the first file but applies to all.

[laeubi]

@akurtakov yes I need to split / cleanup this and open CQ for the files imported from bndtools.
This PR is manly to keep track of open issues (e.g. currently it can't build because of some missing features e.g. eclipse-equinox/equinox#415 and eclipse-platform/eclipse.platform.releng.aggregator#1611) and packages should be "internal API" but I'd like to use usual names if other want to reuse these (e.g. bndtools / m2e ...) and javadoc generation would be fine (for me).

[akurtakov]

Please don't merge this one until https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11814 and https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11813 are approved.
Licensecheck doesn't check dependencies if they are only in target platform but not referenced by any bundle as maven-dependency-plugin doesn't report them. To fix that licensecheck would have to be run not only for the aggregator repo but for each repo so one would see the failure here after addition to the target platform. I would really appreciate if you add this check.

[laeubi]

Yes I need to rebase this PR then the IP lab issues will be shown here as well.

[akurtakov]

Yes I need to rebase this PR then the IP lab issues will be shown here as well.

I don't see licensecheck being run here at all, are you sure issues will be shown?

[laeubi]

Yes I need to rebase this PR then the IP lab issues will be shown here as well.

I don't see licensecheck being run here at all, are you sure issues will be shown?

If not that should be maybe considered an error? @HannesWell is there any reason the check is not run for PDE repo?

[HannesWell]

Yes I need to rebase this PR then the IP lab issues will be shown here as well.

I don't see licensecheck being run here at all, are you sure issues will be shown?

If not that should be maybe considered an error? @HannesWell is there any reason the check is not run for PDE repo?

There is no blocker. I think the reason why it only ran for eclipse.platform.releng.aggregator was that that repo contains the sdk.target and therefore sees new artifacts first, except for cases like this one.
So no problem to enable it for PDE too.

[laeubi]

All different parts are merged now, this needs a rebase / resolve conflicts now for the PDE parts....

[laeubi]

N&N is here: eclipse-platform/www.eclipse.org-eclipse#112

[jukzi]

My Workspace does not find org.eclipse.pde.bnd.ui.wizards.ProjectTemplateParam

[laeubi]

The you probably missing the project org.eclipse.pde.bnd.ui

[basilevs]

@laeubi I'm getting following error on

Eclipse IDE for Eclipse Committers (includes Incubating components)
Version: 2024-03 M2 (4.31.0 M2)
Build id: 20240201-1440

java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Button.removeSelectionListener(org.eclipse.swt.events.SelectionListener)" because "this.cancelButton" is null
	at org.eclipse.jface.wizard.WizardDialog.aboutToStart(WizardDialog.java:401)
	at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1026)
	at org.eclipse.pde.internal.ui.wizards.plugin.NewPluginProjectWizard.getAvailableCodegenWizards(NewPluginProjectWizard.java:209)
	at org.eclipse.pde.internal.ui.wizards.plugin.NewPluginProjectWizard.addPages(NewPluginProjectWizard.java:118)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:634)
	at org.eclipse.jface.window.Window.create(Window.java:431)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1092)
	at org.eclipse.ui.internal.actions.NewWizardShortcutAction.run(NewWizardShortcutAction.java:119)
	at org.eclipse.ui.internal.quickaccess.providers.WizardElement.execute(WizardElement.java:41)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4365)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3988)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1042)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:152)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:648)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:143)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:439)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:271)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:651)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:588)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1459)

I've created some plugin projects, deleted them all and now am trying to create one again.

UPDATE: Nevermind, I see it is tracked in #1097