Shortcut to Target Platform preferences in editor

This helps when a user wants to switch between target definitions without the need of either navigating to another target definition file or the preference page listing all Target Platforms. Resolves #1281
eclipse-pde · Jun 2, 2024 · 78661d2 · 78661d2
1 parent d92416a
commit 78661d2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java
@@ -39,6 +39,8 @@ public class PDEUIMessages extends NLS {
 
 	public static String AbstractTargetPage_reloadTarget;
 
+	public static String AbstractTargetPage_openPreferences;
+
 	public static String AddActivationHeaderResolution_label;
 
 	public static String AddAutomaticModuleResolution_desc;

diff --git a/....eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java b/....eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java
@@ -70,6 +70,7 @@
 import org.eclipse.pde.internal.ui.PDEPlugin;
 import org.eclipse.pde.internal.ui.PDEPluginImages;
 import org.eclipse.pde.internal.ui.PDEUIMessages;
+import org.eclipse.pde.internal.ui.preferences.TargetPlatformPreferencePage;
 import org.eclipse.pde.internal.ui.shared.target.ITargetChangedListener;
 import org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup;
 import org.eclipse.pde.internal.ui.shared.target.TargetLocationsGroup;
@@ -87,6 +88,7 @@
 import org.eclipse.ui.IWorkbenchPage;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.PlatformUI;
+import org.eclipse.ui.dialogs.PreferencesUtil;
 import org.eclipse.ui.dialogs.SaveAsDialog;
 import org.eclipse.ui.forms.AbstractFormPart;
 import org.eclipse.ui.forms.HyperlinkGroup;
@@ -406,8 +408,19 @@ public void run() {
 		export.setToolTipText("Export"); //$NON-NLS-1$
 		export.setImageDescriptor(PDEPluginImages.DESC_EXPORT_TARGET_TOOL);
 
+		Action openTPPreference = new Action("openTPPreference") { //$NON-NLS-1$
+			@Override
+			public void run() {
+				String pageId = TargetPlatformPreferencePage.PAGE_ID;
+				PreferencesUtil.createPreferenceDialogOn(getSite().getShell(), pageId, null, null).open();
+			}
+		};
+		openTPPreference.setToolTipText(PDEUIMessages.AbstractTargetPage_openPreferences);
+		openTPPreference.setImageDescriptor(PDEPluginImages.DESC_SETTINGS_OBJ);
+
 		form.getToolBarManager().add(setAsTarget);
 		form.getToolBarManager().add(export);
+		form.getToolBarManager().add(openTPPreference);
 		form.getToolBarManager().add(help);
 		form.updateToolBar();
 

diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
@@ -488,6 +488,7 @@ SchemaAttributeDetails_use=Use:
 AbstractPluginBlock_counter={0} out of {1} selected
 AbstractTargetPage_setTarget=Set as Active Target Platform
 AbstractTargetPage_reloadTarget=Reload Target Platform
+AbstractTargetPage_openPreferences=Open 'Target Platform' preference (lists all available target)
 ###### Launchers #######################################
 MainTab_name = &Main
 MainTab_AttributeLabel_LauncherPDEVersion=PDE version