Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css issues #1285

Merged
merged 6 commits into from
Aug 1, 2024
Merged

fix: css issues #1285

merged 6 commits into from
Aug 1, 2024

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis commented Aug 1, 2024

  • there was an issue with the loading of coreUI.css from the index.html file in production builds
  • this moves coreUI to be a bundled css file
  • this also removes an invalid import of branding.css that was unrelated, but throwing a browser console error
  • this also fixes broken loading of logos and other static config assets

addresses: #1027 Bootstrap 5 css not loading in pass-ui production build

@jaredgalanis jaredgalanis requested a review from markpatton August 1, 2024 12:33
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branding.css warning is gone from the log.

The header is displayed. Should it have a logo? If so, the logo is missing.

I tested doing a submission and looked through all the tables. The formatting seems fine.

@jaredgalanis jaredgalanis merged commit f958f7f into main Aug 1, 2024
4 checks passed
@jaredgalanis jaredgalanis deleted the fix-css-issues branch August 1, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants