fix: use default ember test scripts in package.json #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredgalanis
commented
Jul 7, 2024
jaredgalanis
commented
- this fixes an issue with concurrently where both the noserve and serve scripts were being run at the same time causing an error when we switched to pnpm
- the default setup in ember is what this PR proposes
- this fixes an issue with concurrently where both the noserve and serve scripts were being run at the same time causing an error when we switched to pnpm - the default setup in ember is what this PR proposes
jabrah
approved these changes
Jul 8, 2024
jaredgalanis
deleted the
fix-use-default-ember-test-scripts-in-package.json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.