-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ensure safe component.string deprecation #1270
refactor: remove ensure safe component.string deprecation #1270
Conversation
1ed5d6f
to
b045c2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grant end date is not displayed in the grants table.
The submitted date is not displayed in the submissions table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I was able to do a submission locally. I looked at all the tables and they seemed fine.
For completeness I noticed the following warnings in the console, but they may be addressed by the other deprecation work.
deprecate.js:131 DEPRECATION: Router location 'auto' is deprecated. Most users will want to set `locationType` to 'history' in config/environment.js for no change in behavior. See deprecation docs for details. [deprecation id: deprecate-auto-location] This will be removed in Ember 5.0.0. See https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location for more details.
at logDeprecationStackTrace (http://localhost:8080/app/assets/vendor.js:20104:21)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at raiseOnDeprecation (http://localhost:8080/app/assets/vendor.js:20133:9)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at handleDeprecationWorkflow (http://localhost:8080/app/assets/vendor.js:94674:9)
at http://localhost:8080/app/assets/vendor.js:94630:72
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at deprecationCollector (http://localhost:8080/app/assets/vendor.js:94709:5)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
deprecate.js:131 DEPRECATION: The `detect` method on the Location object is deprecated. If you need detection you can run your detection code in app.js, before setting the location type. [deprecation id: deprecate-auto-location] This will be removed in Ember 5.0.0. See https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location for more details.
at logDeprecationStackTrace (http://localhost:8080/app/assets/vendor.js:20104:21)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at raiseOnDeprecation (http://localhost:8080/app/assets/vendor.js:20133:9)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at handleDeprecationWorkflow (http://localhost:8080/app/assets/vendor.js:94674:9)
at http://localhost:8080/app/assets/vendor.js:94630:72
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
at deprecationCollector (http://localhost:8080/app/assets/vendor.js:94709:5)
at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
warn.js:59 WARNING: You pushed a record of type 'publication' with a relationship 'journal' configured as 'async: false'. You've included a link but no primary data, this may be an error in your payload. EmberData will treat this relationship as known-to-be-empty.
2
warn.js:59 WARNING: You pushed a record of type 'funder' with a relationship 'policy' configured as 'async: false'. You've included a link but no primary data, this may be an error in your payload. EmberData will treat this relationship as known-to-be-empty.
de68ded
to
814f55e
Compare
b9384aa
to
335a384
Compare
This one involves removing the following deprecation:
https://github.com/embroider-build/embroider/blob/main/docs/replacing-component-helper.md