refactor: remove non strict and non explicit relationships deprecation #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredgalanis
force-pushed
the
refactor-fix-non-strict-and-non-explicit-relationships
branch
from
97ca4a1 to
c52502b
Compare
jaredgalanis
changed the title
markpatton
approved these changes
May 29, 2024
markpatton
approved these changes
May 29, 2024
There was a problem hiding this comment.
I noticed these warnings in the console:
warn.js:59 WARNING: You pushed a record of type 'funder' with a relationship 'policy' configured as 'async: false'. You've included a link but no primary data, this may be an error in your payload. EmberData will treat this relationship as known-to-be-empty.
click @ index.js:1072
warn.js:59 WARNING: You pushed a record of type 'publication' with a relationship 'journal' configured as 'async: false'. You've included a link but no primary data, this may be an error in your payload. EmberData will treat this relationship as known-to-be-empty.
When I look at the funder.js and publication.js models I see they have the async: false, inverse: null which were removed from the others.
Base automatically changed from
refactor-update-deprecation-workflow-list
to
main
June 27, 2024 10:35
jaredgalanis
deleted the
refactor-fix-non-strict-and-non-explicit-relationships
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one involves the following deprecations:
https://deprecations.emberjs.com/ember-data/v4.x#toc_ember-data-deprecate-non-strict-relationships
This one we already got for free by upgrading ember simple auth in the process of the auth refactoring:
ember-simple-auth.initializer.setup-session-restoration