Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh workflows for complete release workflow #1266

Merged
merged 3 commits into from
May 17, 2024

Conversation

rpoet-jh
Copy link
Contributor

Needed for complete workflow fixes PR: eclipse-pass/main#983

Updated ci workflow to trigger on same events as pass-core/pass-support.

Changed update docker images workflow to trigger on PR merge.

@rpoet-jh rpoet-jh self-assigned this May 17, 2024
@rpoet-jh rpoet-jh requested a review from markpatton May 17, 2024 12:33
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thought is will that if condition pass on a manually triggered job?
Should it check for ```
github.event_name == 'workflow_dispatch'

@rpoet-jh rpoet-jh merged commit 00bd94a into main May 17, 2024
4 checks passed
@rpoet-jh rpoet-jh deleted the russ-907-complete-release-wf-fixes branch August 1, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants