Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session data shape bug #1264

Merged
merged 4 commits into from
May 7, 2024
Merged

fix: session data shape bug #1264

merged 4 commits into from
May 7, 2024

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis requested a review from markpatton May 6, 2024 19:17
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good as well as the test.

But there does seem to be one regression. I'm noticing that the whoami service is getting called on every click.

@jaredgalanis jaredgalanis requested a review from markpatton May 6, 2024 21:15
@jaredgalanis
Copy link
Contributor Author

The code looks good as well as the test.

But there does seem to be one regression. I'm noticing that the whoami service is getting called on every click.

@markpatton, it was the new setup method that's required after bumping ember-simple-auth that was calling restore every time.

I was not transitioning in my testing because I was running without the backend. The latest change just moves where setup is called until after we have verified that we are not authenticated.

Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't see multiple whoami calls anymore.

@jaredgalanis jaredgalanis merged commit 1bf82fe into main May 7, 2024
4 checks passed
@jaredgalanis jaredgalanis deleted the fix-session-data-shape-bug branch May 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants