Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't call authenticate on every visit to check session #1262

Merged
merged 1 commit into from
Apr 25, 2024
Merged

refactor: don't call authenticate on every visit to check session #1262

merged 1 commit into from
Apr 25, 2024

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis commented Apr 25, 2024 •
edited
Loading

  • The UI was sending a request to whoami on every route visit
  • This avoids that by only authenticating if a session doesn't already exist

@jaredgalanis jaredgalanis requested a review from markpatton April 25, 2024 14:39
markpatton
markpatton approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it works.

@jaredgalanis jaredgalanis merged commit 59eaf02 into main Apr 25, 2024
4 checks passed
@jaredgalanis jaredgalanis deleted the refactor-don't-call-authenticate-on-every-visit-to-checksession branch April 25, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredgalanis @markpatton