Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pass-auth authenticated service with user service #1260

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Replace pass-auth authenticated service with user service #1260

merged 8 commits into from
Apr 22, 2024

Conversation

markpatton
Copy link
Contributor

@markpatton markpatton commented Mar 18, 2024 •
edited
Loading

Changes

  • Remove CSP header from the Dockerfile,
    • It is done by pass-core
  • No longer have nginx handle not found by serving out index.html
    • It is handled by pass-core.
  • Switch to using /user/whoami to figure out loggedin user
  • Remove no longer needed routes
  • Remove favicon configuration code, just require a favicon.png.

Related prs:

@markpatton markpatton mentioned this pull request Mar 18, 2024
Merged
@markpatton markpatton mentioned this pull request Apr 2, 2024
Merged
@markpatton markpatton requested a review from jaredgalanis April 2, 2024 19:09
@markpatton markpatton linked an issue Apr 16, 2024 that may be closed by this pull request
Consolidate pass-auth and pass-docker reverse proxy functionality into pass-core eclipse-pass/main#903
Closed
@markpatton markpatton marked this pull request as ready for review April 22, 2024 11:43
jaredgalanis
jaredgalanis approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@markpatton markpatton merged commit b39df3d into main Apr 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate pass-auth and pass-docker reverse proxy functionality into pass-core
2 participants
@markpatton @jaredgalanis