Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update deprecation workflow list #1258

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis commented Mar 6, 2024

This is in support of eclipse-pass/main#546

This follows sets up the deprecation removal workflow described here:

https://github.com/mixonic/ember-cli-deprecation-workflow?tab=readme-ov-file#workflow

The PRs that follow this one have had the deprecation turned on to throw and then removed once tests are safely passing.

@jaredgalanis jaredgalanis requested a review from jabrah March 6, 2024 13:31
@jaredgalanis jaredgalanis force-pushed the refactor-update-deprecation-workflow-list branch from 05b1784 to c4d5c73 Compare May 24, 2024 14:52
@jaredgalanis jaredgalanis force-pushed the refactor-update-deprecation-workflow-list branch from c4d5c73 to 153a939 Compare May 24, 2024 14:53
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stood this up locally in pass-docker. The UI seems to work ok. The deprecations warnings are gone except for these below:

deprecate.js:131 DEPRECATION: Router location 'auto' is deprecated. Most users will want to set `locationType` to 'history' in config/environment.js for no change in behavior. See deprecation docs for details. [deprecation id: deprecate-auto-location] This will be removed in Ember 5.0.0. See https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location for more details.
        at logDeprecationStackTrace (http://localhost:8080/app/assets/vendor.js:20104:21)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at raiseOnDeprecation (http://localhost:8080/app/assets/vendor.js:20133:9)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at handleDeprecationWorkflow (http://localhost:8080/app/assets/vendor.js:94674:9)
        at http://localhost:8080/app/assets/vendor.js:94630:72
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at deprecationCollector (http://localhost:8080/app/assets/vendor.js:94709:5)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
deprecate.js:131 DEPRECATION: The `detect` method on the Location object is deprecated. If you need detection you can run your detection code in app.js, before setting the location type. [deprecation id: deprecate-auto-location] This will be removed in Ember 5.0.0. See https://emberjs.com/deprecations/v4.x#toc_deprecate-auto-location for more details.
        at logDeprecationStackTrace (http://localhost:8080/app/assets/vendor.js:20104:21)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at raiseOnDeprecation (http://localhost:8080/app/assets/vendor.js:20133:9)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at handleDeprecationWorkflow (http://localhost:8080/app/assets/vendor.js:94674:9)
        at http://localhost:8080/app/assets/vendor.js:94630:72
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
        at deprecationCollector (http://localhost:8080/app/assets/vendor.js:94709:5)
        at HANDLERS.<computed> (http://localhost:8080/app/assets/vendor.js:20211:9)
```

@jaredgalanis jaredgalanis merged commit cd2ef74 into main Jun 27, 2024
4 checks passed
@jaredgalanis jaredgalanis deleted the refactor-update-deprecation-workflow-list branch June 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants