Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission deletion #1256

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Submission deletion #1256

merged 4 commits into from
Feb 27, 2024

Conversation

jabrah
Copy link
Contributor

@jabrah jabrah commented Feb 22, 2024 •
edited
Loading

Related: eclipse-pass/main#549

pass-core PR: eclipse-pass/pass-core#81

Will require some pass-core changes to add delete permissions on appropriate objects

Changes

  • Update submission delete logic:
    • Delete Files on a draft submission
    • Delete Publication when possible
    • Finally, delete the Submission
    • Errors either thrown directly or passed
  • Update submission-action-cell which has a Delete button
    • Add flash message on submission deletion error instead of relying on default error handling
  • Update submission deletion logic in submission details page to show a flash message on submission deletion error
    • Normalize behavior to match behavior with submission-action-cell

@jabrah jabrah requested a review from jaredgalanis February 22, 2024 15:10
@jabrah jabrah marked this pull request as ready for review February 22, 2024 16:18
@jabrah jabrah mentioned this pull request Feb 22, 2024
Merged
@jabrah jabrah merged commit 6445cf0 into main Feb 27, 2024
4 checks passed
@jabrah jabrah deleted the 549-submission-deletion branch February 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabrah @jaredgalanis