Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update readme #1252

Merged
merged 1 commit into from
Jan 29, 2024
Merged

refactor: update readme #1252

merged 1 commit into from
Jan 29, 2024

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis commented Jan 29, 2024 •
edited
Loading

@jaredgalanis jaredgalanis requested a review from jabrah January 29, 2024 15:42
@markpatton markpatton self-requested a review January 29, 2024 16:40
jabrah
jabrah approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@jabrah jabrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine to me. Removing a bunch of the unnecessary detail will probably make it less of a burden to keep up to date. Interested to see if someone not deep in pass-ui would need any more instruction on running and testing though

markpatton
markpatton approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to follow the instructions.

@jaredgalanis jaredgalanis merged commit f2decc1 into main Jan 29, 2024
3 checks passed
@jaredgalanis jaredgalanis deleted the refactor-update-readme branch January 29, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrah jabrah jabrah approved these changes

@markpatton markpatton markpatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the pass-ui README
3 participants
@jaredgalanis @markpatton @jabrah