Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI shouldn't send empty requests to metadata schema service #1251

Merged
merged 2 commits into from
Jan 24, 2024
Merged

UI shouldn't send empty requests to metadata schema service #1251

merged 2 commits into from
Jan 24, 2024

Conversation

jabrah
Copy link
Contributor

@jabrah jabrah commented Jan 24, 2024 •
edited
Loading

Resolves eclipse-pass/main#876

  • Converts proxies where necessary with toArray()
  • Prevents REST call when no or empty args passed to service

@jabrah jabrah requested a review from jaredgalanis January 24, 2024 19:54
@jabrah jabrah merged commit b71c883 into main Jan 24, 2024
3 checks passed
@jabrah jabrah deleted the 876-intermittent-schema-service-failures branch January 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PASS production reported a call to the schema service without being passed any repository ids
2 participants
@jabrah @jaredgalanis