New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad URL in contact link on 404 page #1244

Merged

jabrah merged 2 commits into main from 806-fix-404-link

Dec 18, 2023

Contributor

jabrah commented Dec 18, 2023 •

edited

Loading

Fixes eclipse-pass/main#806

Update 404 page to handle missing contact link

Changes

Get rid of the template string, which would report undefined values as string literal 'undefined'
- Message when URL is undefined changed to "Please contact your administrator"
Is it fine to get rid of the stand alone get in this context?
Update 404 page template
- Don't add link if contact URL is not defined
- Small restructure

jabrah added 2 commits

December 18, 2023 14:43


          Update 404 page to handle missing contact link. Small template refactor

a747a93


          Fix bad tag close

d1241a3

jabrah requested a review from jaredgalanis

December 18, 2023 19:53

jaredgalanis approved these changes

View reviewed changes

jabrah merged commit 2826a42 into main

3 checks passed

jabrah deleted the 806-fix-404-link branch

December 18, 2023 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet