fix: publication title not updating after amending it #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredgalanis
commented
Oct 19, 2023
| @@ -65,7 +65,7 @@ export default class SubmissionsNewBasics extends Controller { | |||
|
|
|||
| @action | |||
| async loadTab(gotoRoute) { | |||
| if (!this.doiInfo.title) set(this, 'doiInfo.title', get(this, 'publication.title')); | |||
There was a problem hiding this comment.
This is the actual change that fixed things for the bug.
There was a problem hiding this comment.
Note, stashing this information on a piece of Doi Info is something maybe we should consider changing earlier. It took me a while to even hunt this down in part because of the naming.
Also note, you can proceed initially with a DOI and then backtrack and remove it and use a manually inputted title and journal and this still all works.
jabrah
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: eclipse-pass/main#763