Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deposit requirement modal copy #1231

Merged
merged 4 commits into from
Oct 19, 2023
Merged

fix: deposit requirement modal copy #1231

merged 4 commits into from
Oct 19, 2023

Conversation

jaredgalanis
Copy link
Contributor

@jaredgalanis jaredgalanis commented Oct 19, 2023 •
edited
Loading

@jaredgalanis jaredgalanis requested a review from jabrah October 19, 2023 14:36
jabrah
jabrah reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jabrah jabrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me to clarify the actions here, but I'm not sure if it fully resolves the UX point raised in the ticket, since IMO it's still as easy to breeze past the checkbox without reading the label

jabrah
jabrah approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jabrah jabrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once tests are fixed

@jaredgalanis jaredgalanis merged commit e81c484 into main Oct 19, 2023
2 checks passed
@jaredgalanis jaredgalanis deleted the fix-deposit-requirement-modal-copy branch October 19, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabrah jabrah jabrah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Deposit requirements for JScholarship UX
2 participants
@jaredgalanis @jabrah