Fix pagination of proxy user search component #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredgalanis
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good to me. The only thing I'd suggest is removing the two newly generated but empty files. I'm guessing that's some kind of auto-generated behavior based on your editor or something.
As you have mentioned, this is currently a bit difficult to test manually given the lack of users in the db. I can follow up with a PR for an automated test if you want.
|
Oh jeez. I somehow committed some empty files. Will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr corrects the pagination with elide and makes sure we grab the total pages from the meta block of the result.
In addition the user query is normalized so that special characters don't make the query invalid.