fix: add better policy step tests #1224
Conversation
- the factories are filling in data where the fixtures are silent, so the pmcParticipation field on journal was being filled in as A by default. - we should be explicit when creating the journal via the type in method in the journal field in the acceptance tests to pass in pmcPartificpation method
| assert.ok(journal); | ||
| }); | ||
|
|
||
| test('it computes pmcParticipation correctly', function (assert) { |
There was a problem hiding this comment.
this might be the only test that was missing entirely that addresses that regresssion
| @@ -285,7 +285,10 @@ export default function (config) { | |||
| issns: ['Print:0003-2654', 'Online:1364-5528'], | |||
| journalName: 'The Analyst', | |||
| nlmta: 'Analyst', | |||
| pmcParticipation: 'B', | |||
There was a problem hiding this comment.
We need to add this explicitly because otherwise, this default https://github.com/eclipse-pass/pass-ui/pull/1224/files#diff-cd49b43c6fe4ed8bd896068427733aa3dab8fb10d917ab6bf67a0c325b0a6811R7 in the factory overrrides it.
|
|
||
| const submissionAttrs = this.server.create('submission').attrs; |
There was a problem hiding this comment.
This is a pretty common mirage pattern where you aren't actually making a network request to get data and instead are just mocking data for a component. That is to say: create the record in the test db with the factory then grab the attrs so you can use those in creating a record in the store.
| description: 'This is a moo-scription', | ||
| title: 'Moo title', | ||
| id: 1, | ||
| const submissionAttrs = this.server.create('submission').attrs; |
There was a problem hiding this comment.
Pretty much all of the changes in this file involve moving to mirage and factories for the mock data and then also using the new data test selectors to be more declarative about what is being tested.
No description provided.