Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize instructions Url to config.json #1223

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Oct 9, 2023

This PR externalizes the instruction URL in the notice banner to the config.json so it can vary by env.

eclipse-pass/main#690

Copy link
Contributor

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@rpoet-jh rpoet-jh merged commit 8508c2a into main Oct 10, 2023
2 checks passed
@rpoet-jh rpoet-jh deleted the russ-690-instructions-url branch August 1, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make instructions link on PASS UI correct for different environments
2 participants