fix: abort on review step (#1239)

* fix: abort on review step

* don't unload cancelled sub and revert all the other changes

* Remove 'unloadRecord' checks in tests

* Remove commented code

---------

Co-authored-by: John Abrahams <[email protected]>

app/controllers/submissions/new.js

@@ -12,6 +12,7 @@ export default class SubmissionsNew extends Controller {
   @service submissionHandler;
   @service searchHelper;
   @service flashMessages;
+  @service router;
 
   @tracked comment = ''; // Holds the comment that will be added to submissionEvent in the review step.
   @tracked uploading = false;
@@ -138,7 +139,7 @@ export default class SubmissionsNew extends Controller {
       // Clear the shared ignore list, then add the 'deleted' submission ID
       ignoreList.clearIgnore();
       ignoreList.ignore(get(submission, 'id'));
-      this.transitionToRoute('submissions');
+      this.router.transitionTo('submissions');
     }
   }
 }

app/services/submission-handler.js

@@ -242,8 +242,6 @@ export default class SubmissionHandlerService extends Service {
    */
   async deleteSubmission(submission) {
     submission.set('submissionStatus', 'cancelled');
-    return submission.save().then(() => {
-      submission.unloadRecord();
-    });
+    return submission.save();
   }
 }

tests/integration/components/submission-action-cell-test.js

@@ -61,7 +61,7 @@ module('Integration | Component | submission action cell', (hooks) => {
    * supplied submission, then `#save()` should be called
    */
   test('should delete and persist submission', async function (assert) {
-    assert.expect(3);
+    assert.expect(2);
 
     const record = EmberObject.create({
       preparers: A(),
@@ -70,10 +70,6 @@ module('Integration | Component | submission action cell', (hooks) => {
         assert.ok(true);
         return Promise.resolve();
       },
-      unloadRecord() {
-        assert.ok(true);
-        return Promise.resolve();
-      },
       submitter: {
         id: 1,
       },

tests/unit/controllers/submissions/new-test.js

@@ -341,8 +341,10 @@ module('Unit | Controller | submissions/new', (hooks) => {
         },
       })
     );
-    controller.set('transitionToRoute', (name) => {
-      assert.strictEqual(name, 'submissions', 'unexpected transition was named');
+    controller.set('router', {
+      transitionTo: (name) => {
+        assert.strictEqual(name, 'submissions', 'unexpected transition was named');
+      },
     });
 
     controller.send('abort');

tests/unit/services/submission-handler-test.js

@@ -318,16 +318,12 @@ module('Unit | Service | submission-handler', (hooks) => {
    * objects alone
    */
   test('delete submission', function (assert) {
-    assert.expect(4);
+    assert.expect(3);
 
     const submission = EmberObject.create({
       submissionStatus: 'draft',
       publication: EmberObject.create({ title: 'Moo title' }),
       save: () => Promise.resolve(),
-      unloadRecord: () => {
-        assert.ok(true);
-        return Promise.resolve();
-      },
     });
 
     const service = this.owner.lookup('service:submission-handler');