Skip to content

Commit

Permalink
fix: use default ember test scripts in package.json
Browse files Browse the repository at this point in the history
- this fixes an issue with concurrently where both the noserve and serve scripts were being run at the same time causing an error when we switched to pnpm
- the default setup in ember is what this PR proposes
  • Loading branch information
jaredgalanis committed Jul 7, 2024
1 parent 0964c95 commit f489a8e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Install Dependencies
run: pnpm install
- name: Run Tests
run: pnpm run test:no-serve
run: pnpm run test

acceptance-test:
name: "Acceptance test"
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"lint:js:fix": "eslint . --fix",
"start": "ember server",
"test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
"test:no-serve": "ember test",
"test:serve": "ember test -s",
"test:ember": "ember test",
"prepare": "husky install"
},
"devDependencies": {
Expand Down

0 comments on commit f489a8e

Please sign in to comment.