Accessibility best practices (#1237)

* dash * basics * grants * repos * policies * meta * review * revert branding override changes * fix test
eclipse-pass · Oct 23, 2023 · 5f9147e · 5f9147e
1 parent 87244f5
commit 5f9147e
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 19 deletions.
diff --git a/app/components/notice-banner/index.hbs b/app/components/notice-banner/index.hbs
@@ -1,5 +1,5 @@
 {{#if this.displayInfoBanner}}
-  <div class="info-banner p-1 text-center font-weight-bold">
+  <nav class="info-banner p-1 text-center font-weight-bold">
     Need help making a submission? Read our submission workflow
     <a class="instructions-url" href={{this.instructionsUrl}} target="_blank" rel="noopener noreferrer">
       instructions
@@ -11,5 +11,5 @@
       </a>
     {{/if}}
     .
-  </div>
+  </nav>
 {{/if}}
diff --git a/app/components/policy-card/index.hbs b/app/components/policy-card/index.hbs
@@ -1,9 +1,9 @@
 {{! template-lint-disable link-rel-noopener no-action no-triple-curlies require-input-label }}
 <div class="card w-100 my-2" {{did-insert this.setup}}>
   <div class="card-body">
-    <h4 class="card-title" data-test-policy-title>
+    <h3 class="card-title" data-test-policy-title>
       {{@policy.title}}
-    </h4>
+    </h3>
     {{#if this.policyIsJHU}}
       <h6 class="card-subtitle mb-2" data-test-jhu-policy-deposit-expectation>
         Expects deposit into an open access repository

diff --git a/app/components/workflow-grants/index.hbs b/app/components/workflow-grants/index.hbs
@@ -26,9 +26,9 @@
 {{/if}}
 
 {{#if @submission.submitter.id}}
-  <h5>
+  <h4>
     Available grants
-  </h5>
+  </h4>
 
   <p>
     {{#if this.contactUrl}}

diff --git a/app/components/workflow-metadata/index.hbs b/app/components/workflow-metadata/index.hbs
@@ -1,9 +1,9 @@
 {{! template-lint-disable no-action }}
 {{! takes in a schema and the model to save the schema to}}
 <div {{did-insert (perform this.setupSchemas)}}>
-  <h4 class="font-weight-light pull-right form-step-header">
+  <h3 class="font-weight-light pull-right form-step-header">
     {{concat "Form" " " this.displayFormStep " " "of" " " this.schemas.length}}
-  </h4>
+  </h3>
 
   {{#if this.missingRequiredJournal}}
     <h2>Missing required journal</h2>

diff --git a/app/components/workflow-repositories/index.hbs b/app/components/workflow-repositories/index.hbs
@@ -1,9 +1,9 @@
 {{! template-lint-disable no-action require-button-type }}
 <div {{did-insert this.setupRepos}}></div>
 {{#if @requiredRepositories}}
-  <h4 class="mt-3 font-weight-light" data-test-workflow-repositories-required>
+  <h3 class="mt-3 font-weight-light" data-test-workflow-repositories-required>
     Required repositories
-  </h4>
+  </h3>
   <p class="lead text-muted">
     Based on the grant and journal information provided, you are required to submit your manuscript to the repositories
     below. PASS will help you to create submissions for these in the following steps:

diff --git a/app/components/workflow-review/index.hbs b/app/components/workflow-review/index.hbs
@@ -16,9 +16,9 @@
     <div class="list-group">
       <div href="#" class="list-group-item flex-column align-items-start">
         <div class="d-flex w-100 justify-content-between">
-          <h5 class="mb-1" data-test-workflow-review-title>
+          <h4 class="mb-1" data-test-workflow-review-title>
             {{@publication.title}}
-          </h5>
+          </h4>
           <small class="text-muted">
             {{@submission.dateSubmitted.date-time}}<br />{{@submission.dateCreated.date-time}}
           </small>
@@ -128,12 +128,12 @@
                 <table local-class="files-table" class="w-100">
                   <thead>
                     <tr>
-                      <th scope="col"></th>
+                      <th scope="col">File Type</th>
                       <th scope="col" class="font-weight-light">
                         Name
                       </th>
                       <th scope="col" class="font-weight-light">
-                        Type
+                        Manuscript/Supplement
                       </th>
                       <th scope="col" class="font-weight-light">
                         Description

diff --git a/app/components/workflow-wrapper/index.hbs b/app/components/workflow-wrapper/index.hbs
@@ -19,9 +19,9 @@
     />
   </div>
   <div class="row justify-content-center">
-    <main class="col-lg-12">
+    <div class="col-lg-12">
       {{yield}}
-    </main>
+    </div>
   </div>
 
   {{#if (and @submissionEvents @submission.isProxySubmission)}}

diff --git a/app/templates/application.hbs b/app/templates/application.hbs
@@ -32,7 +32,7 @@
   <div id="navbar-container">
     <NavBar @fullWidth={{this.fullWidth}} />
   </div>
-  <div class="container-fluid site-content">
+  <main class="container-fluid site-content">
     <div class="flash-message-container">
       {{#each this.flashMessages.queue as |flash|}}
         <FlashMessage @flash={{flash}} as |component flash close|>
@@ -48,7 +48,7 @@
 
     {{this.institution}}
     {{outlet}}
-  </div>
+  </main>
   <footer class="app-footer justify-content-center mt-3">
     <div class="text-center p-1">
       {{#if this.contactUrl}}

diff --git a/tests/integration/components/workflow-metadata-test.js b/tests/integration/components/workflow-metadata-test.js
@@ -176,7 +176,7 @@ module('Integration | Component | workflow-metadata', (hooks) => {
       />
     `);
 
-    const header = find('h4');
+    const header = find('h3');
     await waitUntil(() => {
       return header.textContent.includes(expected);
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,9 +26,9 @@ @@
     {{/if}}
     {{#if @submission.submitter.id}}
-      <h5>
+      <h4>
         Available grants
-      </h5>
+      </h4>
       <p>
         {{#if this.contactUrl}}
@@ Expand Down @@