fix: allow proxy submission to submit without manuscript

eclipse-pass · Jul 1, 2024 · 3b8aa1f · 3b8aa1f
1 parent 5219b46
commit 3b8aa1f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/controllers/submissions/new.js b/app/controllers/submissions/new.js
@@ -86,7 +86,8 @@ export default class SubmissionsNew extends Controller {
 
     manuscriptFiles = _.uniqBy(manuscriptFiles, 'id');
 
-    if (manuscriptFiles.length == 0 && this.userIsSubmitter) {
+    const submitter = await this.userIsSubmitter();
+    if (manuscriptFiles.length == 0 && submitter) {
       swal('Manuscript Is Missing', 'At least one manuscript file is required.  Please go back and add one', 'warning');
     } else if (manuscriptFiles.length > 1) {
       swal(

diff --git a/app/routes/submissions/new.js b/app/routes/submissions/new.js
@@ -55,7 +55,9 @@ export default class NewRoute extends CheckSessionRoute {
     if (params.submission) {
       // Operating on existing submission
 
-      newSubmission = await this.store.findRecord('submission', params.submission, { include: 'publication.journal' });
+      newSubmission = await this.store.findRecord('submission', params.submission, {
+        include: 'publication.journal,submitter',
+      });
       publication = await newSubmission.get('publication');
       journal = publication.get('journal');