Grant loader configuration cleanup #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpatton
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made in this PR:
-Converted grant loader to spring boot application.
-Removed need to load connection.properties file on runtime. Now spring boot configuration files are used. Env vars will be set on docker images at runtime for needed properties.
-Added ability to read policy.properties from S3 bucket.
-Uses spring boot IOC to remove bunch of boiler plate code for managing object wiring/configuration.
-Updated JHU grant loader code to be annotated with
@Profile("jhu")to use spring Profiles to configure grant loader for particular institution at runtime.-Added few more tests to improve test coverage.
This PR is for eclipse-pass/main#888