Fix failed deposit retry submission status bug #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On deposit failed retry so repoCopy has publication if retry succeeds and repoCopy is created.
markpatton
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the failed deposit retry code where if the deposit succeeded, when the RepositoryCopy object was created, the associated Publication of the Submission was null, so the associated Publication of the RepositoryCopy was null. This causes the Submission status update logic to fall down because it requires that the submission Deposit.RepositoryCopy have a matching Publication in order to update submission status.
PR with script to fix null repo_copy.publication_id in stage database is here: eclipse-pass/pass-core#69
The PR in pass-core should be merged after this PR is merged and deployed to stage.