Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warnings in deposit-services #138

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix compile warnings in deposit-services #138

merged 2 commits into from
Nov 20, 2024

Conversation

rpoet-jh
Copy link
Contributor

This PR:

  • Fixes all compile warnings.
  • Disables javadoc "missing message" warning. I'll create a separate issue to address the missing javadoc comments.

@rpoet-jh rpoet-jh requested a review from markpatton November 19, 2024 15:13
@rpoet-jh rpoet-jh self-assigned this Nov 19, 2024
@rpoet-jh rpoet-jh linked an issue Nov 19, 2024 that may be closed by this pull request
Fix compile warnings in deposit services eclipse-pass/main#1082
Closed
markpatton
markpatton approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup.

@rpoet-jh rpoet-jh merged commit 8e9639d into main Nov 20, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1082-depsvc-compile-warnings branch November 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees

@rpoet-jh rpoet-jh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix compile warnings in deposit services
2 participants
@rpoet-jh @markpatton