Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #133

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Upgrade dependencies #133

merged 3 commits into from
Nov 11, 2024

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Nov 8, 2024

Upgrade all dependencies for pass-support modules. Few notable changes:

  • In nihms-loader, change PmidLookup to use OkHttp instead of outdated HttpClient4.
  • In deposit-services, had to add config property pass.deposit.nihms.email.ssl.checkserveridentity so nihms email service ITs could pass with GreenMail.
  • For modules that are SpringBoot, changed slf4j/logback deps to be used from spring-boot-dependencies pom import.

@rpoet-jh rpoet-jh requested a review from markpatton November 8, 2024 15:20
@rpoet-jh rpoet-jh self-assigned this Nov 8, 2024
@rpoet-jh rpoet-jh linked an issue Nov 8, 2024 that may be closed by this pull request
Upgrade backend PASS dependencies eclipse-pass/main#1076
Closed
markpatton
markpatton approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice cleanup and update. Tests pass for me locally.

@rpoet-jh rpoet-jh merged commit 3a63c68 into main Nov 11, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1076-upgrade-deps branch November 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees

@rpoet-jh rpoet-jh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade backend PASS dependencies
2 participants
@rpoet-jh @markpatton