Deployment tests data cleanup enhancements #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsande16
approved these changes
Jul 17, 2024
| ResponseEntity<Void> csrfResponse = restClient.get() | ||
| .uri("/security/csrf") | ||
| .exchange((request, response) -> new ResponseEntity<>(null, response.getHeaders(), HttpStatus.OK)); | ||
| String xsrfToken = csrfResponse.getHeaders().get("DSPACE-XSRF-TOKEN").get(0); |
There was a problem hiding this comment.
May want to null check on this in case DSPACE-XSRF-TOKEN is null or empty list. Possibly log if it's null. This would be helpful with debugging.
| .body(bodyPair) | ||
| .retrieve() | ||
| .toBodilessEntity(); | ||
| String authToken = authResponse.getHeaders().get("Authorization").get(0); |
There was a problem hiding this comment.
May want a null check here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been made to the deployment tests data cleanup feature:
pass.test.skip.depositsthat istrueby default. If this property is true, any deposit for a submission associated with the deployment test grant will not be deposited into the downstream repository.DevNullTransportthat will be used in the skip deposits case that will do nothing with the package contents but will create theRepositoryCopyand set the Deposit.depositStatus toACCEPTED.pass.test.skip.depositsisfalse, then the deployment tests deposits will be made in the downstream repositories.DspaceDepositServiceis used to delete the DSpace deposits. The deposit will be deleted from DSpace in about an hour after it was created.DspaceDepositServicecode is invoked as part of theDeploymentTestDataJobwhich run periodically to clean up deployment test data.