Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 support for grant loader file operations #109

Merged
merged 5 commits into from
May 3, 2024
Merged

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented May 2, 2024

Now the grant loader can use S3 (if enabled) for all file operations. For example, the grant-data file can be read and written from an S3 bucket if the file path is an S3 url (s3://).

The grant loader now uses Spring Resources for reading/writing the grant data, grant update timestamp, and policy.properties files. This is the abstraction that performs the appropriate reading and writing depending on the resource URL. For files on a disk, file URLs (file://) should be used, for files in an S3 bucket, s3 URLs (s3://) should be used.

@rpoet-jh rpoet-jh requested a review from markpatton May 2, 2024 19:41
@rpoet-jh rpoet-jh self-assigned this May 2, 2024
@rpoet-jh rpoet-jh force-pushed the russ-930-full-s3 branch from 3918ef6 to 1f1d82e Compare May 3, 2024 11:53
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Passes for me locally.

@rpoet-jh rpoet-jh merged commit 1dd503a into main May 3, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the russ-930-full-s3 branch August 1, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to write read/write grant data files via S3
2 participants