Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment test data job #105

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Add deployment test data job #105

merged 7 commits into from
Apr 24, 2024

Conversation

rpoet-jh
Copy link
Contributor

This PR adds a new job to the deposit service's jobs. The Job is responsible for managing the deployment test data in live environments. The job will create the deployment test grant data if it doesn't exist, and it will delete submissions (and all related data) related to the test grant after 24 hours. The job will run every 12 hours and should only be enabled when running in a live environment (stage or prod).

This is needed to support the deployment tests PR: eclipse-pass/pass-acceptance-testing#17

@rpoet-jh rpoet-jh requested review from jabrah and jaredgalanis April 18, 2024 16:09
@rpoet-jh
Copy link
Contributor Author

@jaredgalanis @jabrah I added both of you as an FYI so you can see how the deployment test data is being managed.

@rpoet-jh
Copy link
Contributor Author

I realized I need to delete the submission File data too. I'll add that today, but it won't change what is here already, just add to it.

@rpoet-jh
Copy link
Contributor Author

I realized I need to delete the submission File data too. I'll add that today, but it won't change what is here already, just add to it.

This is done.

Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass. I think cleaning up the test data here is a sensible solution.

@rpoet-jh rpoet-jh merged commit bb70c7d into main Apr 24, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the russ-909-deploy-tests branch August 1, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants