Modify pass-core test container to use basic auth in wait strategy. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his is needed for new version of pass-core.
|
The changes to testcontainers look fine. However, pass-data-client and pass-journal-loader use the io.fabric8 docker plugin to run the ITs, and it has the 401 wait condition too. |
|
@rpoet-jh The docker plugin tests pass fine because pass-core doesn't initiate saml login when they hit the test urls. In contrast the testcontainers wait test looked like a browser without the basic auth header set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for new version of pass-core which takes over the reverse proxy role.