Change nihms-loader startDate arg to harvestMonths #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpoet-jh
force-pushed
the
russ-811-nihms-start-duratin
branch
from
2e55053 to
9e2623e
Compare
rpoet-jh
changed the title
To match nihms default value and to make arg help clearer.
tsande16
approved these changes
Mar 14, 2024
|
Also tested without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the nihms-loader
startDatedate argument toharvestMonthswhich is time period (number of months). Now instead of a date value,harvestMonthscan be set to the number of months in the past to harvest the nihms data files. For example, to pull the past 3 months of nihms data, set--harvestMonths=3. This works better for scheduled batch execution.