Cleanup

eclipse-pass · Jul 8, 2024 · 8084e37 · 8084e37
1 parent a196970
commit 8084e37
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 197 deletions.
diff --git a/pass-nihms-loader/nihms-data-harvest/pom.xml b/pass-nihms-loader/nihms-data-harvest/pom.xml
@@ -90,13 +90,13 @@
   </dependencies>
 
   <build>
-    <finalName>nihms-data-harvest-cli</finalName>
     <plugins>
       <plugin>
         <groupId>org.springframework.boot</groupId>
         <artifactId>spring-boot-maven-plugin</artifactId>
         <configuration>
           <mainClass>org.eclipse.pass.loader.nihms.NihmsHarvesterCLI</mainClass>
+          <finalName>nihms-data-harvest-cli</finalName>
           <classifier>exec</classifier>
         </configuration>
         <executions>

diff --git a/...ms-data-transform-load/src/main/java/org/eclipse/pass/loader/nihms/entrez/PmidLookup.java b/...ms-data-transform-load/src/main/java/org/eclipse/pass/loader/nihms/entrez/PmidLookup.java
@@ -55,8 +55,6 @@ public class PmidLookup {
      * delayed responses.
      * https://www.ncbi.nlm.nih.gov/books/NBK25497/
      */
-    /*private static final String DEFAULT_ENTREZ_PATH = "https://eutils.ncbi.nlm.nih.gov/entrez/eutils/esummary" +
-                                                      ".fcgi?db=pubmed&retmode=json&rettype=abstract&id=%s";*/
     @Value("${pmc.entrez.service.url}")
     private String ENTREZ_PATH;
 

diff --git a/...ansform-load/src/test/java/org/eclipse/pass/loader/nihms/entrez/EntrezPmidLookupTest.java b/...ansform-load/src/test/java/org/eclipse/pass/loader/nihms/entrez/EntrezPmidLookupTest.java
@@ -33,7 +33,6 @@
 import org.json.JSONObject;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.mock.mockito.MockBean;
 import org.springframework.test.context.TestPropertySource;
@@ -52,9 +51,6 @@ public class EntrezPmidLookupTest {
     // Needed so tests can run after application starts
     @MockBean private NihmsTransformLoadCLIRunner nihmsTransformLoadCLIRunner;
 
-    @Value("${pmc.entrez.service.url}")
-    private String ENTREZ_PATH;
-
     @Test
     public void testGetEntrezRecordJson() throws IOException, URISyntaxException {
         String entrez = IOUtils.toString(getClass().getClassLoader().

diff --git a/pass-nihms-loader/nihms-data-transform-load/src/test/resources/pmid_record_ascii.json b/pass-nihms-loader/nihms-data-transform-load/src/test/resources/pmid_record_ascii.json