Add try-with-resources

eclipse-pass · Apr 29, 2024 · 0e6fac2 · 0e6fac2
1 parent 2c11ca7
commit 0e6fac2
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/pass-data-client/src/main/java/org/eclipse/pass/support/client/JsonApiPassClient.java b/pass-data-client/src/main/java/org/eclipse/pass/support/client/JsonApiPassClient.java
@@ -681,11 +681,14 @@ public void deleteFile(File file) throws IOException {
             .addEncodedPathSegments(file.getUri().getRawPath().substring(1)).build();
 
         Request requestFileBin = new Request.Builder().url(urlFileBin).delete().build();
-        Response responseFileBin = client.newCall(requestFileBin).execute();
-
-        if (!responseFileBin.isSuccessful() && responseFileBin.code() != 404) {
-            throw new IOException(String.format("Failed to delete for File: %s, URL: %s, Status code: %d",
-                file.getId(), urlFileBin, responseFileBin.code()));
+        try (Response responseFileBin = client.newCall(requestFileBin).execute()) {
+            if (responseFileBin.code() == 404) {
+                return;
+            }
+            if (!responseFileBin.isSuccessful()) {
+                throw new IOException(String.format("Failed to delete for File: %s, URL: %s, Status code: %d",
+                    file.getId(), urlFileBin, responseFileBin.code()));
+            }
         }
 
         deleteObject(file);