Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pass-core user env names #380

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Oct 7, 2024

This PR is changing the pass-core user env var names to align with the changes made the pass-core optional AWS parameter store PR eclipse-pass/pass-core#93.

The pass-core will need to be merge before tests pass for this PR. To test locally, pull the dev branch for the pass-core PR, run mvn clean install. Then you should be able to start pass-docker local with the config in this PR.

@rpoet-jh rpoet-jh requested a review from markpatton October 7, 2024 18:17
@rpoet-jh rpoet-jh self-assigned this Oct 7, 2024
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rpoet-jh rpoet-jh force-pushed the rdp-1046-paramstore-config branch from ba3175a to 2672a28 Compare October 8, 2024 18:08
@rpoet-jh rpoet-jh merged commit b8dc1e0 into main Oct 8, 2024
1 of 2 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1046-paramstore-config branch October 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants