Change CORS Access Control headers in proxy server #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Access-Control-Allow-Origin
header was set to*
allowing any domain to make a CORS request. I have changed this so that theAccess-Control-Allow-Origin
will be set tohttps://domainname
.I also removed the access control headers since allowing the browser to default is recommended. Additionally, I didn't see any requests where a header named
authorization
was being returned, so theAccess-Control-Expose-Headers
appeared to be not relevant to PASS.I tested these changes locally and on stage, and logging into pass worked fine.