Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean default application configuration and property values #96

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

rpoet-jh
Copy link
Contributor

The following changes are in this PR:

  • Change application.yaml so the default configuration is setup for production use. This means no default values for sensitive or institutional specific configuration properties. Note there is no production profile now, it is the default configuration.
  • Create application-test.yaml that has configuration property values for local running and testing. This includes moving the src/main/resources/saml2 directory to src/test/resources/saml2.
  • Remove docker compose files since they seemed outdated. pass-docker can be used to run pass-core.
  • Update README to reflect configuration changes.

@rpoet-jh
Copy link
Contributor Author

Acceptance tests will fail until the pass-docker PR eclipse-pass/pass-docker#382 is merged. Even then, the acceptance tests will fail because of current issue with testcafe and chrome, but...

Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good cleanup. I tested locally and it behaved as expected when choosing the default (produciton) or test profiles.

@rpoet-jh rpoet-jh merged commit bb5e7b0 into main Oct 25, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1066-app-prop-default-cleanup branch November 1, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default values from sensitive application properties
2 participants