Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete permissions for Submission and Publication #81

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Add Delete permissions for Submission and Publication #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pass-core-main/src/test/java/org/eclipse/pass/main/security/AccessControlTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ public void testCreateUpdateDeleteSubmissionAsShibUser() throws IOException, JSO

Response response = client.newCall(request).execute();

check(response, 403);
check(response, 204);
}
}

Expand Down Expand Up @@ -373,7 +373,7 @@ public void testCreateUpdateDeletePublicationAsShibUser() throws IOException, JS

Response response = client.newCall(request).execute();

check(response, 403);
check(response, 204);
}
}

Expand Down
2 changes: 2 additions & 0 deletions pass-core-object-service/src/main/java/org/eclipse/pass/object/model/Publication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import java.util.Objects;

import com.yahoo.elide.annotation.CreatePermission;
import com.yahoo.elide.annotation.DeletePermission;
import com.yahoo.elide.annotation.Include;
import com.yahoo.elide.annotation.UpdatePermission;
import jakarta.persistence.Column;
Expand All @@ -33,6 +34,7 @@

@CreatePermission(expression = "User is Backend OR User is Submitter")
@UpdatePermission(expression = "User is Backend OR User is Submitter")
@DeletePermission(expression = "User is Backend OR User is Submitter")
@Include
@Entity
@Table(name = "pass_publication")
Expand Down
2 changes: 2 additions & 0 deletions pass-core-object-service/src/main/java/org/eclipse/pass/object/model/Submission.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.Objects;

import com.yahoo.elide.annotation.CreatePermission;
import com.yahoo.elide.annotation.DeletePermission;
import com.yahoo.elide.annotation.Include;
import com.yahoo.elide.annotation.UpdatePermission;
import jakarta.persistence.Column;
Expand All @@ -44,6 +45,7 @@

@CreatePermission(expression = "User is Backend OR User is Submitter")
@UpdatePermission(expression = "User is Backend OR Object part of User Submission")
@DeletePermission(expression = "User is Backend OR Object part of User Submission")
@Include
@Entity
@Table(name = "pass_submission")
Expand Down
Loading