-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete Release Workflow #980
Conversation
Adds one workflow to release all PASS modules and set the next snapshot version.
de52120
to
cf68d4a
Compare
@markpatton I was looking around at the repos and actions, and I think for the Snapshot steps in this workflow, the only thing that we really have to do is update the version to dev next version and push the commit. The building/publishing/docker image pushing all look to happen already in existing workflows in each repo. I think I can remove all those steps from the complete workflow, right? |
@markpatton actually, looking at this closer, there is an issue with how I have commits pushing for the release and snapshot for each repo. Each push will start the |
@markpatton sorry for the multiple comments, but I think I can clean this up by using a |
@markpatton I have made the following changes to address this issue:
Once the 5 PRs have been merged, I will run another RC release test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really well done and should save a lot of time.
The tag checks and careful organization means this should be able to be restarted again with most transient failures.
The use of tags together with atomic commits and modifications to the other repo workflows to avoid building the dev versions again is a great optimization.
This is a workflow that will release all PASS modules. It builds on the approach in the Release Java Modules. The workflow requires a
Release Version
andNext dev version
as input. In order to run the workflow, a PAT needs to be set like instructed in the Release Java Workflow instructions.I tried to make the workflow so that is can be re-run in the case where one of the steps fails for some reason. As one can see, there are several steps where failure can occur, so the workflow may not be re-runnable in all failure scenarios, but should cover the most common cases.
I will work on updating the release documentation once this workflow is reviewed/merged.
Note, I had to merge an initial version of
pass-complete-release.yml
to main so I could run tests, thus the diff in the file instead of being new.