-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release actions and notes for 1.2.0 #851
Conversation
- Removed pass-ui-public from the release components. No longer released since 0.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, a couple suggested tweaks, but otherwise this looks good.
docs/release-notes.md
Outdated
## Release v1.2.0 | ||
### Date: November 30, 2023 | ||
|
||
This release focused on increasing the security of PASS and making interactions with external services more robust, notably the interface with NIHMS. Parameterized queries were added to the grant loader to enhance security. We've made substantial upgrades to the NIHMS data transfer within our Deposit Services and enhancements to the NIHMS loader. Updates were made to the data model documentation. A new JHU logo has been introduced and client-side pagination support has been added in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check on the inclusion of the JHU logo in the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified with Jared. This should not be in the release-notes as this is JHU specific. I have removed JHU logo language.
Co-authored-by: Bill Branan <[email protected]>
- accept suggestion Co-authored-by: Bill Branan <[email protected]>
- JHU logo is not part of the community release and is part of the JHU specific deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads well.
All 1.2.0 releases are done and can be found on their respective release pages. Ran
pass-docker
1.2.0 locally and could step through the workflow as several types of users. Tested onpass-demo
and was successfully submitting a couple submissions as various users.Once this PR is merged the final outstanding steps to do are:
Note: Removed pass-ui-public from the release components. No longer released since 0.6.0