Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export dependencies #485

Merged

Conversation

Aposhian
Copy link
Contributor

When building with PAHO_WITH_MQTT_C and/or PAHO_WITH_SSL, the package config file doesn't correctly bring in these additional dependencies. This fixes that, so upstream projects pulling this in don't have to call find_package themselves on these dependencies.

Signed-off-by: Adam Aposhian <[email protected]>
@fpagliughi
Copy link
Contributor

I have a PR up on the Paho C repo addressing some build issues that has been sitting for a few months now...
eclipse-paho/paho.mqtt.c#1428

And I have some additional code that I was waiting to push until a decision was made on that one, as far as which way to go. I think somewhere in there I addressed this issue.

In addition, there's another PR here, #471, which also addresses similar build issues. As I stated there, I'm waiting on the upstream decision to even look at any build issues.

So, I guess, leave this here for now, and when there's any action on the C build, we can try to rebase and merge all this stuff.

@fpagliughi
Copy link
Contributor

fpagliughi commented Jun 15, 2024

I've given up waiting for the upstream release! I'll get this in with the v1.4 release of this library...

Thanks.

@fpagliughi fpagliughi merged commit 2d329af into eclipse-paho:master Jun 15, 2024
1 check passed
@Aposhian Aposhian deleted the export-dependencies branch June 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants