Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl engine #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shawshank119
Copy link

add ssl engine mode for load private key.

@fpagliughi
Copy link
Contributor

Hey, thanks for the PR, and sorry for the slow response.

Obviously this is blocked by the PR to the Paho C library:
eclipse-paho/paho.mqtt.c#1247

Also, the changes to the ssl_options constructor parameter order would technically be a breaking change. It would be better to add the parameters with default values at the end of the parameter list. That wouldn't break existing code. But, obviously, the C update needs to be addressed first.

@fpagliughi fpagliughi added the upstream Problem with upstream library label Nov 15, 2023
@Pascal-Fremaux
Copy link

Pascal-Fremaux commented Oct 23, 2024

@fpagliughi Be careful that the ENGINE lib support is deprecated in Open SSL 3.0 and removed from further 3.x releases.
So this should be limited to OpenSSL 1.x usage.
This is replaced by the Provider plugins with new APIs.
https://docs.openssl.org/3.0/man7/migration_guide/#upgrading-from-openssl-102

@fpagliughi
Copy link
Contributor

@Pascal-Fremaux , thanks for the heads up. I never got around to looking at this, waiting on the C lib, but I wouldn’t look to implement this if it’s just a 1.x thing. OpenSSL is one library that I think people shouldn’t keep using old versions. Gotta stay ahead of the exploits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Problem with upstream library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants