Fix IpV6 link local address connections #1466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumoog
changed the title
Paho currently successfully resolves IPv6 link-local addresses (of the form `tcp://[xxxx::xxxx:xxxx:xxxx%eth0]:1883`). But it does not copy the resolved link information over when attempting to make the connection. This is a 3-line fix. See: eclipse-paho#1464
|
What needs to happen to get this change landed and released? We're running (@ my employer) with a local vendored fork (+ Rust bindings) and would prefer to be using upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IpV6 link local address connections
Paho currently successfully resolves IPv6 link-local addresses (of the
form
tcp://[xxxx::xxxx:xxxx:xxxx%eth0]:1883). But it does not copythe resolved link information over when attempting to make the
connection.
This is a 3-line fix.
See: #1464