Tidy up a bit #62

Task-Url: https://github.com/eclipse-mylyn/org.eclipse.mylyn/issues/issues/62
eclipse-mylyn · Oct 19, 2023 · 2c241c7 · 2c241c7
1 parent d628ac0
commit 2c241c7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/...n.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java b/...n.github.ui/src/org/eclipse/mylyn/internal/github/ui/gist/GistRepositorySettingsPage.java
@@ -45,7 +45,7 @@ public GistRepositorySettingsPage(TaskRepository taskRepository) {
 		super(Messages.GistRepositorySettingsPage_Title,
 				Messages.GistRepositorySettingsPage_Description, taskRepository);
 		setNeedsAnonymousLogin(false);
-		setUseToken(true, false);
+		setUseTokenForAuthentication(false);
 	}
 
 	@Override

diff --git a/...github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java b/...github.ui/src/org/eclipse/mylyn/internal/github/ui/issue/IssueRepositorySettingsPage.java
@@ -47,7 +47,7 @@ public IssueRepositorySettingsPage(final TaskRepository taskRepository) {
 		super(Messages.IssueRepositorySettingsPage_Title,
 				Messages.IssueRepositorySettingsPage_Description,
 				taskRepository);
-		setUseToken(true, true);
+		setUseTokenForAuthentication(true);
 
 	}
 

diff --git a/...hub.ui/src/org/eclipse/mylyn/internal/github/ui/pr/PullRequestRepositorySettingsPage.java b/...hub.ui/src/org/eclipse/mylyn/internal/github/ui/pr/PullRequestRepositorySettingsPage.java
@@ -47,7 +47,7 @@ public PullRequestRepositorySettingsPage(final TaskRepository taskRepository) {
 		super(Messages.PullRequestRepositorySettingsPage_Title,
 				Messages.PullRequestRepositorySettingsPage_Description,
 				taskRepository);
-		setUseToken(true, true);
+		setUseTokenForAuthentication(true);
 
 	}
 

diff --git a/...mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java b/...mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/wizards/AbstractRepositorySettingsPage.java
@@ -281,7 +281,7 @@ public abstract class AbstractRepositorySettingsPage extends AbstractTaskReposit
 	/**
 	 * @since 4.1
 	 */
-	private boolean useTokenForAuthentication;
+	private boolean useTokenForAuthentication = false;
 
 	private boolean userOptional = true;
 
@@ -2489,8 +2489,8 @@ public boolean isUserOptional() {
 	 * @param userOptional
 	 *            Allow username as well as token
 	 */
-	public void setUseToken(final boolean useTokenForAuthentication, final boolean userOptional) {
-		this.useTokenForAuthentication = useTokenForAuthentication;
+	public void setUseTokenForAuthentication(final boolean userOptional) {
+		this.useTokenForAuthentication = true;
 		this.userOptional = userOptional;
 	}