-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: error handling for unexpected error in DefaultRegistrationEngine #944
Closed
moznion
wants to merge
9
commits into
eclipse-leshan:1.x
from
moznion:933_backport_unexpected_err_handler_1.x
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
31e2970
#933: Add new interfaces to core: Destroyable, Startable and Stoppable
moznion d8ce2c5
#933: Mark as deprecated for server.(Destroyable, Startable, Stoppable)
moznion c830d08
#933: Implement Destroyable, Startable and Stoppable for ObjectEnabler
moznion a3585e6
#933: Implement Destroyable, Startable and Stoppable for LwM2mObjectTree
moznion 1ea225e
#933: Add an interface `LwM2mClientObserver2` to handle unexpected erorr
moznion 1a8fecb
#933: Call `onUnexpectedError()` when unexpected error occurred
moznion c918c93
#933: Set an unexpected error hook to destroy the demo client
moznion c67e3dd
#933: Correct the access level of a member variable
moznion 00f1e5a
#933: Add comment for each deprecated interface
moznion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I'm not too boring with this but are you sure we should keep the backward compatibility behavior ?
As I said in #941 (comment), we could maybe consider the current behavior as a bug rather as a behavior which should not be changed ?
WDYT ?
Of course if you insist we can only add this behavior to
LeshanClientDemo
but it's hard to me to find why keeping a kind of process zombie alive should be a good idea.(#933 (comment))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this has been a point for consideration.
The previous pull-request (#941) was for the new major version 2.0, on the other hand, this pull-request aims to update the current stable version. So I'm a little bit afraid of breaking the backward compatibility...
But, as you mentioned, it is difficult to find out the reason to encourage keeping the living-dead client process.
This is just my opinion, it would be better to set the hook in
LeshanClinet
; but anyway I'd like to follow and respect the decision of this project. Let's do the same thing with #941?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I cherrypick the commit from master instead of the one in this PR.