Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback mechanism into LwM2mClientObserver for when the unexpected error occurred #941

Closed
wants to merge 7 commits into from
Closed

Add callback mechanism into LwM2mClientObserver for when the unexpected error occurred #941

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e3a324
#933: Add method: `onUnexpectedErrorOccurred()` for LwM2mClientObserver
moznion Nov 30, 2020
7e32bf5
#933: Handle unexpected errors on `DefaultRegistrationEngine`
moznion Nov 30, 2020
e3aad0d
#933: Add demo code to shutdown when an unexpected error has occurred
moznion Nov 30, 2020
16c6cb7
#933: Rename: s/onUnexpectedErrorOccurred/onUnexpectedError/g
moznion Dec 3, 2020
3f73020
#933: Implement Destroyable, Startable and Stoppable on ObjectEnabler
moznion Dec 3, 2020
7e6d029
#933: register ShutdownOnUnexpectedErrorObserver for LeshanClient
moznion Dec 3, 2020
b4a89c9
#933: format code
moznion Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions leshan-client-core/src/main/java/org/eclipse/leshan/client/observer/LwM2mClientObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,8 @@ void onDeregistrationFailure(ServerIdentity server, DeregisterRequest request, R
String errorMessage, Exception cause);

void onDeregistrationTimeout(ServerIdentity server, DeregisterRequest request);

// ============== Unexpected Error Handling =================

void onUnexpectedErrorOccurred(Throwable unexpectedError);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe onUnexpectedError is enough ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the advice, I've not had confidence in this honestly :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed at 16c6cb7

}
4 changes: 4 additions & 0 deletions ...ent-core/src/main/java/org/eclipse/leshan/client/observer/LwM2mClientObserverAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,8 @@ public void onDeregistrationFailure(ServerIdentity server, DeregisterRequest req
@Override
public void onDeregistrationTimeout(ServerIdentity server, DeregisterRequest request) {
}

@Override
public void onUnexpectedErrorOccurred(Throwable unexpectedError) {
}
}
6 changes: 6 additions & 0 deletions ...-core/src/main/java/org/eclipse/leshan/client/observer/LwM2mClientObserverDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,10 @@ public void onDeregistrationTimeout(ServerIdentity server, DeregisterRequest req
}
}

@Override
public void onUnexpectedErrorOccurred(Throwable unexpectedError) {
for (LwM2mClientObserver observer : observers) {
observer.onUnexpectedErrorOccurred(unexpectedError);
}
}
}